feat(metricprovider): allow user to define metrics.provider.job.metadata #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidalgopl
force-pushed
the
add-labels-and-annotation-from-job-metrics-provider-to-job
branch
from
74d2812
to
a5e7cbc
Compare
…o created Jobs metadata Signed-off-by: Paweł Bojanowski <pbojanowski@protonmail.com>
hidalgopl
force-pushed
the
add-labels-and-annotation-from-job-metrics-provider-to-job
branch
from
a5e7cbc
to
0006ae4
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2762 +/- ##
=======================================
Coverage 81.64% 81.64%
=======================================
Files 133 133
Lines 20172 20178 +6
=======================================
+ Hits 16469 16475 +6
Misses 2849 2849
Partials 854 854
☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
approved these changes
May 9, 2023
|
Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels and annotations specified in AnalysisTemplate
.spec.metrics.provider.job.metadatawill be copied to the created Jobs.discussed with @zachaller on Slack: https://cloud-native.slack.com/archives/C01U781DW2E/p1683298745937339