Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add some details around running locally to make things clearer new contributors #2786

Merged
merged 1 commit into from May 17, 2023

Conversation

meeech
Copy link
Contributor

@meeech meeech commented May 17, 2023

This is a minor docs improvement.

Checklist:

  • [n/a] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • [n/a] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • [n/a] My organization is added to USERS.md.

…ople new to the project.

Signed-off-by: mitchell amihod <4623+meeech@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented May 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zachaller zachaller enabled auto-merge (squash) May 17, 2023 16:47
@github-actions
Copy link
Contributor

Go Published Test Results

1 952 tests   1 952 ✔️  2m 36s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 5486061.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (497e69a) 81.64% compared to head (5486061) 81.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2786   +/-   ##
=======================================
  Coverage   81.64%   81.64%           
=======================================
  Files         133      133           
  Lines       20178    20178           
=======================================
  Hits        16475    16475           
  Misses       2849     2849           
  Partials      854      854           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zachaller zachaller merged commit c683ade into argoproj:master May 17, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants