Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update docs of Rollout spec to add active/previewMetadata #2833

Merged
merged 1 commit into from Jun 12, 2023

Conversation

kzap
Copy link
Contributor

@kzap kzap commented Jun 12, 2023

Add blueGreen activeMetadata / previewMetadata as its part of the spec.

This was added back in #974 , its part of the docs in https://github.com/argoproj/argo-rollouts/blob/master/docs/features/ephemeral-metadata.md but not documented as part of the spec

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore. - chore
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Add blueGreen activeMetadata / previewMetadata as its part of the spec.

Signed-off-by: Andre Marcelo-Tanner <andre@ada.support>
@kzap kzap marked this pull request as ready for review June 12, 2023 13:58
@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

Go Published Test Results

1 988 tests   1 988 ✔️  2m 35s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 355b9d4.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

    4 files      4 suites   3h 22m 58s ⏱️
  96 tests   87 ✔️   5 💤   4
394 runs  364 ✔️ 20 💤 10

For more details on these failures, see this check.

Results for commit 355b9d4.

@zachaller zachaller merged commit 3308401 into argoproj:master Jun 12, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants