Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add prometheus timeout #2893

Merged
merged 4 commits into from
Jul 25, 2023

Conversation

AhmedGrati
Copy link
Contributor

@AhmedGrati AhmedGrati commented Jul 19, 2023

Resolves #2892.
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@AhmedGrati AhmedGrati changed the title Feat add prometheus timeout [WIP] feat: Add prometheus timeout Jul 19, 2023
@AhmedGrati AhmedGrati force-pushed the feat-add-prometheus-timeout branch 2 times, most recently from 9abc31d to ed9935b Compare July 19, 2023 21:00
@AhmedGrati AhmedGrati changed the title [WIP] feat: Add prometheus timeout feat: Add prometheus timeout [WIP] Jul 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

Go Published Test Results

2 033 tests   2 033 ✔️  2m 40s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit a39f407.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (20e00e4) 81.68% compared to head (a39f407) 81.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2893      +/-   ##
==========================================
+ Coverage   81.68%   81.72%   +0.03%     
==========================================
  Files         133      133              
  Lines       20309    20336      +27     
==========================================
+ Hits        16589    16619      +30     
+ Misses       2862     2860       -2     
+ Partials      858      857       -1     
Files Changed Coverage Δ
metricproviders/prometheus/prometheus.go 87.76% <100.00%> (+1.15%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 33m 40s ⏱️
102 tests   91 ✔️   6 💤   5
418 runs  384 ✔️ 24 💤 10

For more details on these failures, see this check.

Results for commit a39f407.

♻️ This comment has been updated with latest results.

@AhmedGrati AhmedGrati force-pushed the feat-add-prometheus-timeout branch 3 times, most recently from 731b89a to 44f66e2 Compare July 23, 2023 12:49
@AhmedGrati AhmedGrati changed the title feat: Add prometheus timeout [WIP] feat: Add prometheus timeout Jul 23, 2023
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.0% 8.0% Duplication

@zachaller zachaller merged commit d8dbb24 into argoproj:master Jul 25, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timeout attribute for prometheus metrics provider
3 participants