Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing rollout fields #3062

Merged
merged 5 commits into from Oct 13, 2023
Merged

Conversation

ashutosh16
Copy link
Contributor

@ashutosh16 ashutosh16 commented Sep 27, 2023

Update AnalysisInfo
https://gist.github.com/ashutosh16/5c6583f2e177ad7d8f7c44fda9dce015

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@ashutosh16 ashutosh16 changed the title chores: add missing rollout fields chore: add missing rollout fields Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ba7c9a5) 81.71% compared to head (7d66164) 81.71%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3062      +/-   ##
==========================================
- Coverage   81.71%   81.71%   -0.01%     
==========================================
  Files         134      134              
  Lines       20416    20432      +16     
==========================================
+ Hits        16683    16695      +12     
- Misses       2873     2876       +3     
- Partials      860      861       +1     
Files Coverage Δ
pkg/kubectl-argo-rollouts/info/analysisrun_info.go 90.69% <100.00%> (+0.69%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

Go Published Test Results

2 045 tests   2 045 ✔️  2m 42s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 7d66164.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 34m 46s ⏱️
102 tests   86 ✔️   6 💤 10
428 runs  386 ✔️ 24 💤 18

For more details on these failures, see this check.

Results for commit 7d66164.

♻️ This comment has been updated with latest results.

@ashutosh16 ashutosh16 marked this pull request as ready for review September 28, 2023 21:28
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
5.7% 5.7% Duplication

@zachaller zachaller merged commit 6d58a42 into argoproj:master Oct 13, 2023
24 checks passed
zachaller pushed a commit that referenced this pull request Oct 25, 2023
* chores: add missing rollout fields

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>

* chores: add missing rollout fields

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>

* chores: add missing rollout fields

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>

* chores: add missing rollout fields

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>

* chores: add missing rollout fields

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>

---------

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-1.6 cherry-pick-completed Used once we have cherry picked the PR to all requested releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants