fix: missing notification on error #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3076 +/- ##
==========================================
- Coverage 81.73% 81.71% -0.02%
==========================================
Files 134 134
Lines 20406 20416 +10
==========================================
+ Hits 16678 16683 +5
- Misses 2869 2873 +4
- Partials 859 860 +1
☔ View full report in Codecov by Sentry. |
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
leoluz
reviewed
Oct 5, 2023
utils/record/record.go
Outdated
| } | ||
| log.Infof("Trigger %s result: %v", trigger, res) | ||
| log.Infof("trigger %s result: %v", trigger, res) |
There was a problem hiding this comment.
nit: Argo CD logs we usually start with uppercase.
| } | ||
|
|
||
| emptyCondition := hash("") | ||
|
|
||
| // We should not return in these loops because we want other configured notifications to still send if they can. | ||
| errors := []error{} |
There was a problem hiding this comment.
Not sure if I am understanding this correctly but I can't find where this list of errors is returned..
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
added a commit
that referenced
this pull request
Oct 5, 2023
* fix: missing notification on error Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix tests Signed-off-by: zachaller <zachaller@users.noreply.github.com> * aggregate errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix bad stat counts Signed-off-by: zachaller <zachaller@users.noreply.github.com> * return errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix tests on return of errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * change case on logs Signed-off-by: zachaller <zachaller@users.noreply.github.com> * missed a case Signed-off-by: zachaller <zachaller@users.noreply.github.com> --------- Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller
added
the
cherry-pick-completed
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 13, 2023
* fix: missing notification on error Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix tests Signed-off-by: zachaller <zachaller@users.noreply.github.com> * aggregate errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix bad stat counts Signed-off-by: zachaller <zachaller@users.noreply.github.com> * return errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix tests on return of errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * change case on logs Signed-off-by: zachaller <zachaller@users.noreply.github.com> * missed a case Signed-off-by: zachaller <zachaller@users.noreply.github.com> --------- Signed-off-by: zachaller <zachaller@users.noreply.github.com> Signed-off-by: Philip Clark <philip.clark@iterable.com>
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 15, 2023
* fix: missing notification on error Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix tests Signed-off-by: zachaller <zachaller@users.noreply.github.com> * aggregate errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix bad stat counts Signed-off-by: zachaller <zachaller@users.noreply.github.com> * return errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix tests on return of errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * change case on logs Signed-off-by: zachaller <zachaller@users.noreply.github.com> * missed a case Signed-off-by: zachaller <zachaller@users.noreply.github.com> --------- Signed-off-by: zachaller <zachaller@users.noreply.github.com> Signed-off-by: Philip Clark <philip.clark@iterable.com>
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 15, 2023
* fix: missing notification on error Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix tests Signed-off-by: zachaller <zachaller@users.noreply.github.com> * aggregate errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix bad stat counts Signed-off-by: zachaller <zachaller@users.noreply.github.com> * return errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix tests on return of errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * change case on logs Signed-off-by: zachaller <zachaller@users.noreply.github.com> * missed a case Signed-off-by: zachaller <zachaller@users.noreply.github.com> --------- Signed-off-by: zachaller <zachaller@users.noreply.github.com> Signed-off-by: Philip Clark <philip.clark@iterable.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notifications would stop processing if any error happened on a single notification 'API' configuration, we should continue processing other notifications so that we do not miss sending a notification that is properly configured.
This also fixes an incorrect prometheus stat, we where only incrementing errors and success counts on api creations not at the sending and erroring of the actually execution of the notification.