Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reference AnalysisTemplates inside an AnalysisTemplate #3353

Merged
merged 10 commits into from
Mar 29, 2024

Conversation

OpenGuidou
Copy link
Contributor

@OpenGuidou OpenGuidou commented Feb 7, 2024

closes #3247

The goal is to have smaller analysisTemplates that can be grouped and shared easily

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: Patch coverage is 83.56164% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 82.85%. Comparing base (8405f2e) to head (948e733).
Report is 66 commits behind head on master.

Files Patch % Lines
rollout/analysis.go 60.00% 9 Missing and 5 partials ⚠️
experiments/experiment.go 90.90% 4 Missing and 2 partials ⚠️
rollout/controller.go 87.09% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3353      +/-   ##
==========================================
+ Coverage   81.83%   82.85%   +1.01%     
==========================================
  Files         135      135              
  Lines       20688    17142    -3546     
==========================================
- Hits        16931    14203    -2728     
+ Misses       2883     2046     -837     
- Partials      874      893      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Go Published Test Results

2 160 tests   2 160 ✅  2m 53s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 948e733.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 45m 7s ⏱️
110 tests  99 ✅  6 💤 5 ❌
448 runs  416 ✅ 24 💤 8 ❌

For more details on these failures, see this check.

Results for commit 948e733.

♻️ This comment has been updated with latest results.

@OpenGuidou OpenGuidou force-pushed the analysisRef branch 2 times, most recently from 430491a to b4f0ef2 Compare February 7, 2024 10:50
@OpenGuidou OpenGuidou force-pushed the analysisRef branch 3 times, most recently from 35dbe95 to 4a88d20 Compare February 20, 2024 09:08
@OpenGuidou
Copy link
Contributor Author

Hi @zachaller , can I get a review on this one please ?

@zachaller zachaller added this to the v1.7 milestone Feb 28, 2024
Signed-off-by: Guillaume Doussin <guillaume.doussin@gmail.com>
Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Passed Quality Gate passed

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
28.9% Duplication on New Code

See analysis details on SonarCloud

@zachaller zachaller merged commit f5793e4 into argoproj:master Mar 29, 2024
23 checks passed
@OpenGuidou OpenGuidou deleted the analysisRef branch April 2, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference an AnalysisTemplate in another AnalysisTemplate
2 participants