Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include the correct response error in the plugin init error message #3388

Merged
merged 1 commit into from Feb 27, 2024

Conversation

chetan-rns
Copy link
Member

Update the plugin init error message to include the correct response error

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues

Measures
0 Security Hotspots
No data about Coverage
6.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Go Published Test Results

2 130 tests   2 130 ✅  2m 50s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit ee55f72.

Copy link
Contributor

E2E Tests Published Test Results

  4 files    4 suites   3h 41m 24s ⏱️
107 tests  94 ✅  6 💤  7 ❌
438 runs  404 ✅ 24 💤 10 ❌

For more details on these failures, see this check.

Results for commit ee55f72.

@zachaller zachaller merged commit e547e57 into argoproj:master Feb 27, 2024
21 checks passed
@zachaller
Copy link
Collaborator

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants