Argo controller had rolled out negative values during the promotion

[sathishmr-zepto]

Checklist:

• I've included steps to reproduce the bug.
• I've included the version of argo rollouts.

Describe the bug

the Argo rollout logs, we discovered that the Argo controller had configured negative values during the canary promotion, consequently triggering the issue.

To Reproduce

Expected behavior

Screenshots

Version
1.60+7eae71e

Logs

# Paste the logs from the rollout controller

# Logs for the entire controller:
kubectl logs -n argo-rollouts deployment/argo-rollouts

2024-05-16 15:15:57.018 | time="2024-05-16T09:45:57Z" level=info msg="Patched: {\"status\":{\"canary\":{\"weights\":{\"canary\":{\"weight\":-25},\"stable\":{\"weight\":125}}}}}" generation=1347 namespace=search-platform resourceVersion=1688392998 rollout=search-service |  
-- | -- | --
  |   | 2024-05-16 15:15:56.984 | time="2024-05-16T09:45:56Z" level=info msg="Event(v1.ObjectReference{Kind:\"Rollout\", Namespace:\"search-platform\", Name:\"search-service\", UID:\"b3856f40-a846-4d04-9d85-a17b7f6c4676\", APIVersion:\"argoproj.io/v1alpha1\", ResourceVersion:\"1688392998\", FieldPath:\"\"}): type: 'Normal' reason: 'TrafficWeightUpdated' Traffic weight updated from 0 to -25" |  
  |   | 2024-05-16 15:15:56.984 | time="2024-05-16T09:45:56Z" level=info msg="Traffic weight updated from 0 to -25" event_reason=TrafficWeightUpdated namespace=search-platform rollout=search-service |  
  |   | 2024-05-16 15:15:56.984 | time="2024-05-16T09:45:56Z" level=info msg="New weights: &TrafficWeights{Canary:WeightDestination{Weight:-25,ServiceName:,PodTemplateHash:fcc6d7569,},Stable:WeightDestination{Weight:125,ServiceName:,PodTemplateHash:58db58969f,},Additional:[]WeightDestination{},Verified:nil,}" namespace=search-platform rollout=search-service |  
  |   | 2024-05-16 15:15:56.984 | time="2024-05-16T09:45:56Z" level=info msg="Previous weights: &TrafficWeights{Canary:WeightDestination{Weight:0,ServiceName:,PodTemplateHash:fcc6d7569,},Stable:WeightDestination{Weight:100,ServiceName:,PodTemplateHash:58db58969f,},Additional:[]WeightDestination{},Verified:nil,}" namespace=search-platform rollout=search-service |  
  |   | 2024-05-16 15:13:36.229 | time="2024-05-16T09:43:36Z" level=info msg="Patched: {\"status\":{\"canary\":{\"weights\":{\"canary\":{\"weight\":60},\"stable\":{\"weight\":40}}},\"conditions\":[{\"lastTransitionTime\":\"2024-05-15T12:27:31Z\",\"lastUpdateTime\":\"2024-05-15T12:27:31Z\",\"message\":\"Rollout has minimum availability\",\"reason\":\"AvailableReason\",\"status\":\"True\",\"type\":\"Available\"},{\"lastTransitionTime\":\"2024-05-16T09:37:51Z\",\"lastUpdateTime\":\"2024-05-16T09:37:51Z\",\"message\":\"Rollout is not healthy\",\"reason\":\"RolloutHealthy\",\"status\":\"False\",\"type\":\"Healthy\"},{\"lastTransitionTime\":\"2024-05-16T09:37:51Z\",\"lastUpdateTime\":\"2024-05-16T09:37:51Z\",\"message\":\"RolloutCompleted\",\"reason\":\"RolloutCompleted\",\"status\":\"False\",\"type\":\"Completed\"},{\"lastTransitionTime\":\"2024-05-16T09:43:36Z\",\"lastUpdateTime\":\"2024-05-16T09:43:36Z\",\"message\":\"Rollout is paused\",\"reason\":\"RolloutPaused\",\"status\":\"False\",\"type\":\"Paused\"},{\"lastTransitionTime\":\"2024-05-16T09:43:36Z\",\"lastUpdateTime\":\"2024-05-16T09:43:36Z\",\"message\":\"ReplicaSet \\\"wms-outbound-86448677c\\\" is progressing.\",\"reason\":\"ReplicaSetUpdated\",\"status\":\"True\",\"type\":\"Progressing\"}],\"currentStepIndex\":17}}" generation=1000 namespace=supply-chain resourceVersion=1688383615 rollout=wms-outbound


# Logs for a specific rollout:
kubectl logs -n argo-rollouts deployment/argo-rollouts | grep rollout=<ROLLOUTNAME

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

[zachaller]

Closed via #3474