Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for replicas_desired #748

Closed
dudadornelles opened this issue Sep 30, 2020 · 0 comments
Closed

Add metric for replicas_desired #748

dudadornelles opened this issue Sep 30, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@dudadornelles
Copy link
Contributor

dudadornelles commented Sep 30, 2020

Summary

Add a new metric rollout_info_replicas_desired to represent the number of replicas you ultimately desire your rollout to have

Use Cases

We are moving from Deployments to Rollouts and having problems migrating our datadog monitors to use the available rollout metrics. We have monitoring around number of replicas unavailable to help us identify degradation of service, but in argo-rollouts, the rollout_info_replicas_unavailable is the number of available rollout replicas which I understand are considered "unavailable" because they aren't live yet?

Either ways, with a replicas_desired metric (which would be simply Rollout.Spec.Replicas) I could calculate the number of really unavailable replicas with desired - available

As reference this is implemented in kube-state-metrics https://github.com/kubernetes/kube-state-metrics/blob/392f9249f808041612a8d3c5348fc48b64cece74/internal/store/deployment.go#L159

Happy to open a PR on this if there is interest.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant