Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintuitive automatic pause behavior for blue green strategy #80

Closed
jessesuen opened this issue May 20, 2019 · 2 comments
Closed

Unintuitive automatic pause behavior for blue green strategy #80

jessesuen opened this issue May 20, 2019 · 2 comments

Comments

@jessesuen
Copy link
Member

jessesuen commented May 20, 2019

The current automatic pause behavior for the blue/green strategy is inconsistent, and hard to explain. Some examples:

  • it does not pause during the initial rollout
  • it does not pause if the preview service is unspecified, but will pause if it is.
  • it does not pause during a fast rollback

These rules are not obvious or documented. I think we need to rework the behavior so that it is more easily predictable.

I also feel the default behavior should be switched to automatically perform a cutover instead of the current behavior of automatically pausing if there is a preview service. This would make it consistent behavior with rolling update, recreate, canary, where the default behavior is to perform the promotion automatically. Just because I don't specify a preview service, doesn't necessarily mean I don't want it to pause, and vice versa.

@jessesuen
Copy link
Member Author

Another problem is that there is no a way to automatically pause a blue green rollout before cutover, unless I specify a preview service.

@jessesuen
Copy link
Member Author

Fixed with spec.autoPromotionEnabled field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant