Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ephemeral Metadata for Blue Green strategy #973

Closed
cooperbenson-qz opened this issue Feb 4, 2021 · 2 comments
Closed

Add Ephemeral Metadata for Blue Green strategy #973

cooperbenson-qz opened this issue Feb 4, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@cooperbenson-qz
Copy link
Contributor

Summary

Functionality for setting ephemeral metadata for Canary rollouts was proposed in #455 and implemented in #770. I would like to extend this functionality to the BlueGreen strategy as well. This would be done by adding previewMetadata and activeMetadata to the BlueGreen spec and using similar reconciliation logic to apply them to the replicasets and pods.

Use Cases

Same use cases as ephemeral metadata for canary rollouts (i.e. tagging metrics with consistent labels). My specific use case is to tag Prometheus metrics with a label if the pod is active and use that for selecting custom HPA metrics.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@cooperbenson-qz
Copy link
Contributor Author

cooperbenson-qz commented Feb 4, 2021

Worth mentioning that I'm planning on authoring a PR for this if there are no objections to the proposed implementation 😄

@jessesuen
Copy link
Member

@cooperbenson-qz this sounds great to have parity for blue-green. No objections to the proposal or you working on this. I'll assign the issue to you. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants