Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: side navbar #221

Open
gaurav5430 opened this issue May 20, 2022 · 6 comments
Open

Accessibility: side navbar #221

gaurav5430 opened this issue May 20, 2022 · 6 comments
Labels
type/bug Something isn't working

Comments

@gaurav5430
Copy link

These are some of the accessibility issues i have identified on the side nav bar, with some quick solutions (may not be the best):

  • there is no indication that this is a menu or nav - can use nav element
  • there is no indication for the current active item for the screenreader user - can use aria-current="true"
  • keyboard users can focus on the next item using tab, but can't activate it using space / Enter - can use button instead of a div with onClick
  • there is a visual change on mouse hover but not on keyboard focus (although the tooltip gets shown, which is an indication that the focus has changed) - apply the same styles as hover
@saumeya
Copy link
Contributor

saumeya commented Jun 21, 2022

@gaurav5430 can you share screenshots of the change, thanks!

@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

@agilgur5 agilgur5 added the type/bug Something isn't working label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants