We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expr
Looks like expr is used mostly via expr.Eval. While it is a valid usage, precompiling expressions on config save/update can detect a lot of errors.
expr.Eval
Consider using expr.Compile. One of the expr features is type checker:
expr.Compile
out, err := expr.Compile(`name + age`) // err: invalid operation + (mismatched types string and int) // | name + age // | .....^
Type checker can infer types from Argo env variables, so there is no need to redefine types for expr.
Detecting errors in expression of configuration save/update.
Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
The text was updated successfully, but these errors were encountered:
This would be a great validation step to add to the operator and CLI, thanks for the suggestion!
Related to the goals of #10017 as well
Sorry, something went wrong.
No branches or pull requests
Summary
Looks like expr is used mostly via
expr.Eval
. While it is a valid usage, precompiling expressions on config save/update can detect a lot of errors.Consider using
expr.Compile
. One of the expr features is type checker:Type checker can infer types from Argo env variables, so there is no need to redefine types for expr.
Use Cases
Detecting errors in expression of configuration save/update.
Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
The text was updated successfully, but these errors were encountered: