Retry a stopped workflow report Ancestor node not found #12156
Comments
|
After adding and printing logs in the 
This caused the 
|
|
Should we ignore the nodes that are marked as diff --git a/workflow/util/util.go b/workflow/util/util.go
index 3083c4f63..8d29536eb 100644
--- a/workflow/util/util.go
+++ b/workflow/util/util.go
@@ -951,7 +951,7 @@ func FormulateRetryWorkflow(ctx context.Context, wf *wfv1.Workflow, restartSucce
}
}
} else {
- if !containsNode(resetParentGroupNodes, node.ID) {
+ if !containsNode(resetParentGroupNodes, node.ID) && node.Phase == wfv1.NodeSucceeded {
log.Debugf("Node %s remains as is", node.Name)
newWF.Status.Nodes.Set(node.ID, node)
}
|
agilgur5
added
the
area/retry-manual
|
Thanks for the investigation here!
Not necessarily. If a |
Thank you for your response. In this example, I attempted to retry the workflow on UI without using the This caused the controller to mark the workflow as being in an |
|
Hi, your change is not true, you only change the code to adapt this sense. |
@hustclf I thought about it again, and my previous statement about using bfs may lead to ambiguity. To be more precise, BFS should first traverse each node, record the dependent nodes (parent nodes) of each node, and then traverse and determine whether the current node should be retained after this operation is completed |
Pre-requisites
:latestWhat happened/what you expected to happen?
What happened
I created a DAG workflow with four tasks (A, B, C, D). When tasks A and B were successfully completed, I stopped the workflow during the execution of task C. After retrying the workflow, I noticed that the workflow's phase immediately changed to 'Error' and displayed an error message stating that the ancestor node 'C' was not found.
what you expected to happen?
I would like to be able to successfully retry a stopped workflow.
Version
v3.4.13
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Logs from the workflow controller
The text was updated successfully, but these errors were encountered: