Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable optional merge queue for this repo #12688

Open
terrytangyuan opened this issue Feb 21, 2024 · 5 comments
Open

Enable optional merge queue for this repo #12688

terrytangyuan opened this issue Feb 21, 2024 · 5 comments
Assignees
Labels
area/build Build or GithubAction/CI issues type/feature Feature request

Comments

@terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan added the type/feature Feature request label Feb 21, 2024
@terrytangyuan terrytangyuan self-assigned this Feb 21, 2024
@terrytangyuan
Copy link
Member Author

@agilgur5 agilgur5 added the area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix label Feb 21, 2024
@agilgur5
Copy link
Member

agilgur5 commented Feb 21, 2024

For reference, this is a follow-up to yesterday's Contributor Meeting, which itself was a follow-up to #12610 (comment) (and further comments) and two prior Slack discussions

@agilgur5 agilgur5 changed the title Enable merge queue for this repo Enable optional merge queue for this repo Feb 21, 2024
@agilgur5 agilgur5 added area/build Build or GithubAction/CI issues and removed area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix labels Feb 21, 2024
@terrytangyuan
Copy link
Member Author

@agilgur5 Do you know any example repos that have this enabled?

@agilgur5
Copy link
Member

agilgur5 commented Mar 26, 2024

Not off the top of my head unfortunately. Been working on this repo primarily for the past bit and merge queues apparently can only be used for repos of an org (and not for personal repos), so I couldn't use my own as examples.

k8s used to have Prow or the k8s bot do this as far as I remember, but some things have changed once GitHub had native features. Bors is the bot that predates the native GH feature, and since it's a bot you can search for its comments (e.g. bors-ng/bors-ng#142).
Merge queues are more similar to the auto-merge feature in that it changes the CI status and leaves a little icon in the PR IIRC, which is not searchable

@agilgur5
Copy link
Member

agilgur5 commented Mar 26, 2024

Ah here's a CNCF example: cncf/presentations#186.

Merge queues are more similar to the auto-merge feature in that it changes the CI status and leaves a little icon in the PR IIRC, which is not searchable

See the little icons that say "added this pull request to the merge queue" and "Merged via the queue":
Screenshot 2024-03-26 at 4 24 32 AM

The feature also adds this link: https://github.com/cncf/presentations/queue/main

And you can see the github-merge-queue[bot] in the (relatively new) "Activity" view, where it creates and deletes temporary branches in order to test: https://github.com/cncf/presentations/activity. But it does not itself make comments, so I found that not by searching on GitHub but by a simple "github merge queue cncf" google search, which had crawled the activity view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues type/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants