Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to open workflow logs in new tab #2887

Closed
dguendisch opened this issue Apr 29, 2020 · 2 comments · Fixed by #2935
Closed

Allow to open workflow logs in new tab #2887

dguendisch opened this issue Apr 29, 2020 · 2 comments · Fixed by #2935
Labels
type/feature Feature request

Comments

@dguendisch
Copy link

The new logging facility option is really great and super useful (#2443)
While the pod log link allows to be opened in a new tab (or directly cmd+click), the same doesn't work for the workflow link on the top.
Is it possible to enable this for the top workflow log link as well?

image

@dguendisch dguendisch added the type/feature Feature request label Apr 29, 2020
@alexec
Copy link
Contributor

alexec commented Apr 29, 2020

Would you like to submit a PR to fix this?

@dguendisch
Copy link
Author

I'm sorry but having never done any html/javascript/typescript/react and judging from a quick look (seeing that the buttons in the pod links are directly styleable and seeing that the buttons from the workflow links come from some more generic page/toolbar and given your comment here https://github.com/argoproj/argo/pull/2443/files#diff-a19f113f6e39d3f31c1d1e776cdf84b3R388) I fear that I'm not capable of changing the code with reasonable efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants