Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL 5.7 bug for null value in timestamp column #2932

Closed
4 tasks done
hashkanna opened this issue May 2, 2020 · 1 comment
Closed
4 tasks done

MySQL 5.7 bug for null value in timestamp column #2932

hashkanna opened this issue May 2, 2020 · 1 comment
Labels

Comments

@hashkanna
Copy link
Contributor

Checklist:

  • I've included the version.
  • I've included reproduction steps.
  • I've included the workflow YAML.
  • I've included the logs.

What happened:
Installation of Argo fails while applying the MySQL YAML manifest for MySQL 5.7 version with error message.
Error 1067: Invalid default value for 'finishedat'

INFO[0000] applying database change                      
change="alter table argo_archived_workflows modify column finishedat timestamp not null"
changeSchemaVersion=16
2020/05/02 18:28:50 	
Session ID: 00001	
Query: alter table argo_archived_workflows modify column finishedat timestamp not null	
Error:  Error 1067: Invalid default value for 'finishedat'	
Time taken: 0.00199s	
Context: context.Background

What you expected to happen:
Expected the installation to succeed.

How to reproduce it (as minimally and precisely as possible):

1. Replace the version of mysql from 8 to 5.7 by changing the image in manifests/quick-start/mysql/mysql-deployment.yaml
2. make start 

Anything else we need to know?:

Environment:

  • Argo version:
$ argo version
argo: v2.7.6+70facdb.dirty  
BuildDate: 2020-04-28T17:09:06Z  
GitCommit: 70facdb67207dbe115a9029e365f8e974e6156bc  
GitTreeState: dirty  
GitTag: v2.7.6  
GoVersion: go1.13.4  
Compiler: gc  
Platform: darwin/amd64
  • Kubernetes version :
$ kubectl version -o yaml
clientVersion:  
  buildDate: "2020-01-18T23:30:10Z"  
  compiler: gc  
  gitCommit: 59603c6e503c87169aea6106f57b9f242f64df89
  gitTreeState: clean  gitVersion: v1.17.2
  goVersion: go1.13.5
  major: "1"
  minor: "17"
  platform: darwin/amd64
serverVersion:
  buildDate: "2020-01-18T23:22:30Z"
  compiler: gc
  gitCommit: 59603c6e503c87169aea6106f57b9f242f64df89
  gitTreeState: clean
  gitVersion: v1.17.2
  goVersion: go1.13.5
  major: "1"
  minor: "17"
  platform: linux/amd64

Message from the maintainers:

If you are impacted by this bug please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@hashkanna
Copy link
Contributor Author

Fixed in #2933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant