Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase checkForbiddenErrorAndResubmitAllowed requeue time #3793

Closed
alexec opened this issue Aug 14, 2020 · 1 comment · Fixed by #3794
Closed

Increase checkForbiddenErrorAndResubmitAllowed requeue time #3793

alexec opened this issue Aug 14, 2020 · 1 comment · Fixed by #3794
Assignees
Labels
type/feature Feature request
Milestone

Comments

@alexec
Copy link
Contributor

alexec commented Aug 14, 2020

Summary

In #3407 we introduced a requeue:

func (woc *wfOperationCtx) checkForbiddenErrorAndResubmitAllowed(err error, nodeName string, tmpl *wfv1.Template) (*wfv1.NodeStatus, error) {
	if (apierr.IsForbidden(err) || apierr.IsTooManyRequests(err)) && isResubmitAllowed(tmpl) {
		// Our error was most likely caused by a lack of resources. If pod resubmission is allowed, keep the node pending
		woc.requeue(0)
		return woc.markNodePending(nodeName, err), nil
	}
	return nil, err
}

This is 0s and therefore will hot loop. Maybe should be 10s?


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@alexec alexec added the type/feature Feature request label Aug 14, 2020
@alexec alexec added this to the v2.10 milestone Aug 14, 2020
@sarabala1979
Copy link
Member

sarabala1979 commented Aug 17, 2020

Yes, It should be 10s. It will reduce the unnecessary load on the K8 API server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants