Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example memoize-simple.yaml is not valid #4626

Closed
brabster opened this issue Dec 2, 2020 · 2 comments · Fixed by #4818
Closed

Example memoize-simple.yaml is not valid #4626

brabster opened this issue Dec 2, 2020 · 2 comments · Fixed by #4818
Labels

Comments

@brabster
Copy link
Contributor

brabster commented Dec 2, 2020

Summary

Examples should validate by the JSON schema.

image

image

Schema or example is wrong. This example will be ignored in the validation test until fixed (see examples/validation_test.go)

Diagnostics

What Kubernetes provider are you using? N/A

What version of Argo Workflows are you running? N/A

Paste the logs from the workflow controller:
kubectl logs -n argo $(kubectl get pods -l app=workflow-controller -n argo -o name) | grep ${workflow}
N/A

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@whynowy
Copy link
Member

whynowy commented Dec 2, 2020

@brabster - would you like to submit a PR to fix it?

@brabster
Copy link
Contributor Author

brabster commented Dec 5, 2020

@whynowy no, I'm not sure whether the schema or the example is right and I don't know the feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants