fix(test): fix TestWFDefaultWithWFTAndWf flakiness (#4507)

Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
argoproj · Nov 11, 2020 · 2dab2d1 · 2dab2d1
1 parent 64ae330
commit 2dab2d1
Showing 1 changed file with 5 additions and 19 deletions.
diff --git a/workflow/controller/operator_wfdefault_test.go b/workflow/controller/operator_wfdefault_test.go
@@ -20,11 +20,7 @@ var wfDefaults = `
   spec: 
     entrypoint: whalesay
     activeDeadlineSeconds: 7200
-    arguments: 
-      artifacts: 
-        -
-          name: message
-          path: /tmp/message
+    arguments:
       parameters: 
         - 
           name: message
@@ -77,11 +73,7 @@ metadata:
     workflows.argoproj.io/archive-strategy: "false"
 spec: 
   activeDeadlineSeconds: 7200
-  arguments: 
-    artifacts: 
-      -
-        name: message
-        path: /tmp/message
+  arguments:
     parameters: 
       - 
         name: message
@@ -141,13 +133,6 @@ var storedSpecResult = `
 {
    "activeDeadlineSeconds": 7200,
    "arguments": {
-      "artifacts": [
-         {
-            "name": "message",
-            "path": "/tmp/message",
-            "url": "http://artifactory:8081/artifactory/generic-local/hello_world.tgz"
-         }
-      ],
       "parameters": [
          {
             "name": "message",
@@ -263,7 +248,6 @@ func TestWFDefaultWithWFTAndWf(t *testing.T) {
 				TTLStrategy:         &ttlStrategy,
 			},
 		}
-		//resultSpec.Arguments.Parameters = append(resultSpec.Arguments.Parameters, args.Parameters...)
 		resultSpec.Entrypoint = "Test"
 		resultSpec.TTLStrategy = &ttlStrategy
 		resultSpec.WorkflowTemplateRef = &wfv1.WorkflowTemplateRef{Name: "workflow-template-submittable"}
@@ -276,10 +260,12 @@ func TestWFDefaultWithWFTAndWf(t *testing.T) {
 
 	t.Run("SubmitComplexWorkflowRefWithArguments", func(t *testing.T) {
 		param := wfv1.Parameter{
-			Name: "Test",
+			Name:  "Test",
+			Value: wfv1.Int64OrStringPtr("welcome"),
 		}
 		art := wfv1.Artifact{
 			Name: "TestA",
+			Path: "tmp/test",
 		}
 
 		ttlStrategy := wfv1.TTLStrategy{