Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.11.6: Parent CronWorkflow 'argo/canary' is malformed #4351

Closed
alexec opened this issue Oct 22, 2020 · 3 comments · Fixed by #4352
Closed

v2.11.6: Parent CronWorkflow 'argo/canary' is malformed #4351

alexec opened this issue Oct 22, 2020 · 3 comments · Fixed by #4352
Assignees
Labels
Milestone

Comments

@alexec
Copy link
Contributor

alexec commented Oct 22, 2020

No description provided.

@alexec alexec self-assigned this Oct 22, 2020
@alexec
Copy link
Contributor Author

alexec commented Oct 22, 2020

Caused by #4320?

@alexec
Copy link
Contributor Author

alexec commented Oct 22, 2020

                woc, ok = cc.cron.Entry(entryId.(cron.EntryID)).Job.(*cronWfOperationCtx)
		if !ok {
			log.Errorf("Parent CronWorkflow '%s' is malformed", nameEntryIdMapKey)
			return true
		}

This must mean that cc.cron.Entry(entryId.(cron.EntryID)).Job is not a *cronWfOperationCtx.

@alexec alexec added this to the v2.11 milestone Oct 22, 2020
@alexec
Copy link
Contributor Author

alexec commented Oct 22, 2020

@sarabala1979 I don't think you change introduced a new bug. I think it revealed an existing one.

I think that because the parent cron-workflow has been deleted, we get nil back. I think this is just fine and we should ignore it (or only warn).

alexec added a commit to alexec/argo-workflows that referenced this issue Oct 22, 2020
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexcapras pushed a commit to alexcapras/argo that referenced this issue Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant