fix(controller): Get correct Step or DAG name. Fixes #2244 #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whynowy
commented
Feb 24, 2020
| if strings.Contains(nodeName, ".") { | ||
| name := nodeName[strings.LastIndex(nodeName, ".")+1:] | ||
| // Check retry scenario |
There was a problem hiding this comment.
Not only retry scenario has (, but also withItems and withParam. Simply removed the retry condition check, and do it for all - This is based on the fact that neither template name nor step/DAG name is allowed to contain (.
Codecov Report
@@ Coverage Diff @@
## master #2304 +/- ##
==========================================
- Coverage 11.44% 11.43% -0.01%
==========================================
Files 71 71
Lines 27860 27868 +8
==========================================
Hits 3188 3188
- Misses 24268 24275 +7
- Partials 404 405 +1
Continue to review full report at Codecov.
|
simster7
approved these changes
Feb 24, 2020
Thanks! will add a functional test for that example. |
alexec
pushed a commit
to alexec/argo-workflows
that referenced
this pull request
Feb 25, 2020
…rgoproj#2304) * fix(controller): Get correct Step or DAG name * Add functional test * Increase wait time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2244
Checklist:
"fix(controller): Updates such and such. Fixes #1234".