fix: Check child node status before backoff in retry #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2407 +/- ##
=========================================
Coverage ? 13.18%
=========================================
Files ? 72
Lines ? 25133
Branches ? 0
=========================================
Hits ? 3315
Misses ? 21402
Partials ? 416
Continue to review full report at Codecov.
|
alexec
reviewed
Mar 10, 2020
| @@ -591,6 +591,17 @@ func (woc *wfOperationCtx) processNodeRetries(node *wfv1.NodeStatus, retryStrate | |||
| return node, true, nil | |||
| } | |||
|
|
|||
| if !lastChildNode.Completed() { | |||
Argo Workflows OSS Kanban Board
automation
moved this from In progress
to Reviewer approved
Mar 12, 2020
alexec
approved these changes
Mar 12, 2020
|
Back-ported to 2.6 |
simster7
added a commit
that referenced
this pull request
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2403. Thanks @cscetbon!