Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move quickstart Prometheus port to 9090 #2487

Merged
merged 3 commits into from Mar 20, 2020

Conversation

simster7
Copy link
Member

No description provided.

Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update hack/port-forward.sh too

@simster7
Copy link
Member Author

you need to update hack/port-forward.sh too

Great catch

@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@063d9bc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2487   +/-   ##
=========================================
  Coverage          ?   11.24%           
=========================================
  Files             ?       73           
  Lines             ?    30902           
  Branches          ?        0           
=========================================
  Hits              ?     3476           
  Misses            ?    26956           
  Partials          ?      470

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 063d9bc...c5fcb36. Read the comment docs.

@simster7 simster7 merged commit bfaf1c2 into argoproj:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants