Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): Support int64 for param value. Fixes #4169 #4202

Merged
merged 17 commits into from Oct 6, 2020
Merged

fix(controller): Support int64 for param value. Fixes #4169 #4202

merged 17 commits into from Oct 6, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Oct 2, 2020 •
edited

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • My organization is added to USERS.md.
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.

Fixes #4169

@alexec alexec added this to the v2.11 milestone Oct 2, 2020
@alexec alexec added P2 and removed P2 labels Oct 2, 2020
@alexec alexec requested a review from simster7 October 2, 2020 21:55
@alexec
Copy link
Contributor Author

alexec commented Oct 3, 2020

FAIL: TestFunctionalSuite/TestParameterAggregation
FAIL: TestFunctionalSuite/TestParametrizableAds
FAIL: TestFunctionalSuite/TestParametrizableLimit

@alexec
Copy link
Contributor Author

alexec commented Oct 3, 2020

run make swagger

@alexec alexec marked this pull request as ready for review October 5, 2020 15:37
@alexec alexec requested a review from jessesuen as a code owner October 5, 2020 15:37
@alexec alexec closed this Oct 5, 2020
@alexec alexec reopened this Oct 5, 2020
simster7
simster7 approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp

@alexec alexec marked this pull request as draft October 5, 2020 19:20
@alexec
Copy link
Contributor Author

alexec commented Oct 5, 2020

Abandoning this work.

  • This will resolve naturally over time as users correct their workflows.
  • It will introduce new bugs.
  • It creates long-term maintanance.

@alexec alexec closed this Oct 5, 2020
@alexec alexec deleted the int64str branch October 5, 2020 19:28
@alexec alexec reopened this Oct 6, 2020
@alexec
Copy link
Contributor Author

alexec commented Oct 6, 2020

This creates problems in any system where we have installed v2.10.

@alexec alexec assigned sarabala1979 and unassigned simster7 Oct 6, 2020
@alexec
Copy link
Contributor Author

alexec commented Oct 6, 2020

@sarabala1979 with @simster7 AFK, could you please review?

@alexec alexec marked this pull request as ready for review October 6, 2020 20:04
@alexec alexec merged commit cac10f1 into argoproj:master Oct 6, 2020
alexec added a commit that referenced this pull request Oct 6, 2020
@alexec
fix(controller): Support int64 for param value. Fixes #4169 (#4202)
51068f7
@alexec alexec linked an issue Oct 7, 2020 that may be closed by this pull request
v2.11.2: Unsuccessful HTTP response #4231
Closed
alexcapras pushed a commit to alexcapras/argo that referenced this pull request Nov 12, 2020
@alexec @alexcapras
fix(controller): Support int64 for param value. Fixes argoproj#4169 (a…
c3f7988 
…rgoproj#4202)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

@jessesuen jessesuen Awaiting requested review from jessesuen

Assignees

@sarabala1979 sarabala1979

Labels
None yet
Projects
None yet
Milestone
v2.11
3 participants
@alexec @simster7 @sarabala1979