Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Audio desync missing in latest version #52

Closed
jack-cole opened this issue Sep 15, 2023 · 13 comments
Closed

Fix Audio desync missing in latest version #52

jack-cole opened this issue Sep 15, 2023 · 13 comments
Labels
wontfix This will not be worked on

Comments

@jack-cole
Copy link

jack-cole commented Sep 15, 2023

After updating the latest version, The Fix Audio Desync option is missing. Now my videos have out of sync audio when I convert them.

image

@argorar
Copy link
Owner

argorar commented Sep 15, 2023

That was a work around to fix some cases, was not 100% accurate, all of the ones I have registered work with last update. Upload a test file.

@jack-cole
Copy link
Author

jack-cole commented Sep 16, 2023

Here is the full video that plays fine in MPV. https://drive.google.com/file/d/1y0PpC8G3bwBquwu7MHmDmomfhxmlHu5H/view?usp=sharing This file is created by Nvidia Shadowplay. I do not have any control over its output, other than framerate and bitrate.

When I use WebMConverter to trim the last part where I am in the car and get shot, the audio is desynced by a few seconds. https://drive.google.com/file/d/1URJisQmSuGffpXPyK3R4Na_e6SV6Tx1b/view?usp=sharing

@argorar
Copy link
Owner

argorar commented Sep 16, 2023

You updated shadowplay recently?
I have a test file made with shadowplay that syncs well. Your video doesn't work with previous webm versions without weird artefacts.

@jack-cole
Copy link
Author

Shadowplay uses variable framerate, so when a game's framerate dips so does the recorded video, which causes issues with syncing the audio. I don't know how MPV and other video applications are able to sync it. I have it set to record at 30FPS, but you can see in the first screenshot it's less than that for the video I sent, while the second screenshot is one without dips.

Video with dips in framerate

Video with no dips in framerate

@argorar
Copy link
Owner

argorar commented Sep 16, 2023

With second file at 30FPS sync right?

@jack-cole
Copy link
Author

These are the settings I use. It chooses 29 fps for that video that has frame dips.
image

@jack-cole
Copy link
Author

#17

@argorar
Copy link
Owner

argorar commented Sep 16, 2023

Your file has different values of tbr:
imagen
Video recorded with shadowplay, correct tbr:
imagen

@argorar
Copy link
Owner

argorar commented Sep 16, 2023

#17

The video provided in that issue sync correctly in latest version.

@jack-cole
Copy link
Author

jack-cole commented Sep 16, 2023

I set my FPS to 30 to save filesize, so the TBR is 30. My recordings can drop below 30 fps due to lag, which is why the TBR doesn't match the FPS.
image

@argorar
Copy link
Owner

argorar commented Sep 16, 2023

That mess internal calculations to determine exact times. If posible use another configuration like 24 fps and test again.

@jack-cole
Copy link
Author

jack-cole commented Sep 16, 2023

I used another application called Handbrake and it was able to sync the audio fine when trimmed to those last ten seconds. I prefer WebMConverter over that since it has a better UI and features. Is it possible to make this work in WebMConverter?

@argorar
Copy link
Owner

argorar commented Sep 17, 2023

It will not in short term. The dependencies with third party libraries make much harder to fix issues related to codecs because the development is dead.

Support in this matter will be dropped from now.

Maybe, one day, these dependencies will be erased to use instead just ffmpeg.

@argorar argorar added the wontfix This will not be worked on label Sep 17, 2023
@argorar argorar closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants