Use mutation observer #11
Conversation
create single instance refactor to remove references to rover Move event functions to higher scope Checks to make reference target nodes
There was a problem hiding this comment.
overall i appreciate it!
i was able to get pretty far with it here https://codepen.io/argyleink/pen/rNpmyXL.
i made some suggestions where i needed to make code changes during testing. really wishin i had good tests for this lib right now! (see #10). making a codepen was the best i had for testing creating multiple instances and deleted them in different ways.
check for target node as a descendant of deleted node
There was a problem hiding this comment.
sorry for lots of comments, it's not a bad sign!
updated the codepen with your latest and gave it a spin (any mods i make i made comments about today, like isRtl).
can confirm it disconnects when there's no more roving elements 👍🏻
major stuff is done, just ironing out the rest. hope this feedback is coming through constructive and positive 🙂
Replacing deprecated Mutation Events with mutationObserver.
Had to move some code around so every instance did not create a new observer.
Mainly the event functions
Cleanup code now part of mutationObserver's callback.