Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change selection of files inside a torrent on the fly #640

Closed
stangri opened this issue Apr 28, 2016 · 13 comments
Closed

Change selection of files inside a torrent on the fly #640

stangri opened this issue Apr 28, 2016 · 13 comments
Milestone

Comments

@stangri
Copy link

stangri commented Apr 28, 2016

Currently the torrent download needs to be stopped, then the selection made and then download to be restarted if you want to select a subset of files in the torrent download.

This is contradictory to other solutions (cough transmission-daemon cough) and is really inconvenient, it cannot even be properly automated by a front end.

Please implement selecting/changing the subset of files to be downloaded within a torrent download "on the fly", without the need to stop it.

@tatsuhiro-t
Copy link
Collaborator

Please check out #644
It still first pauses the download, and then restart it, but it can be completely automated.
The restart is automatically done if aria2.changeOption includes options which are previously only applicable to the waiting or paused downloads.

@tatsuhiro-t tatsuhiro-t added this to the v1.24.0 milestone May 6, 2016
@stangri
Copy link
Author

stangri commented May 6, 2016

Thanks! I've checked out the code, merged it locally with the dynamic-select-file and ran both configure and make. Do I need to update any of my settings? Or just daemonize this new binary?

@tatsuhiro-t
Copy link
Collaborator

No additional settings are required to enable this feature.

@stangri
Copy link
Author

stangri commented May 6, 2016

Tatsuhiro, I can't get it to work with YAAW. :(

  1. How can I confirm if the resulting binary supports this new feature?
  2. Have you tested it by manually creating RPC calls or thru some web front-end?

@binux
Copy link

binux commented May 6, 2016

Tested, it works.
It may take around 5 seconds to take effect (not fully tested, the size of files / # of connected peers may affect the time)

thanks for the feature!

@binux
Copy link

binux commented May 7, 2016

@stangri
The save button is hidden in online demo of YAAW, you can enable it by remove the 'display: none' style.

If you are testing with the disabled options, it will not work, there is a active_task_allowed_options check in yaaw.js, you cannot submit them only by removing the disable attribute.

@tatsuhiro-t
Copy link
Collaborator

There is some delay before the restart since aria2 may have to contact a bittorrent tracker. It might be good to add option to faster restart. The default should be conservative.

@tatsuhiro-t
Copy link
Collaborator

I tested it with aria2rpc cli script. It is found under doc/xmlrpc directory.

@stangri
Copy link
Author

stangri commented May 15, 2016

Now that the 1.2.3 is out, could you please instruct me how can I build the most up-to-date version with this patch applied?

@tatsuhiro-t
Copy link
Collaborator

I merged master to #644

@stangri
Copy link
Author

stangri commented May 16, 2016

Cloned and compiled master, still can't get this to work with YAAW. :(

@tatsuhiro-t
Copy link
Collaborator

It would be better to ask YAAW dev for this.

@tatsuhiro-t
Copy link
Collaborator

Closing since the feature has been implemented and will be available in 1.24.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants