Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: clobber and/or filename when exists #742

Closed
shawnkhall opened this issue Sep 13, 2016 · 6 comments
Closed

feature request: clobber and/or filename when exists #742

shawnkhall opened this issue Sep 13, 2016 · 6 comments

Comments

@shawnkhall
Copy link

#709 resolves one naming problem for downloaded files, but leaves another: there's no clobber support. Skype, for example, always uses the same download filename (SkypeSetup.msi) so even in 1.26.1 I'll get SkypeSetup.1.msi when I download it using aria2 when a another file exists. I'd like to be able to use the same local filename, overwriting the existing SkypeSetup.msi if the new file has the same name.

Alternatively, it would be great if when running a script that calls aria2, it were possible to know what the downloaded filename is if the file is skipped as current. Again, with Skype, if SkypeSetup.msi already exists and is unchanged from my last run of aria2, it will not be downloaded again. But there are no log indications what the filename is for the file that was skipped, only the URL, which does me no good locally.

@tatsuhiro-t
Copy link
Collaborator

--allow-overwrite, perhaps?

@shawnkhall
Copy link
Author

Thank you. allow-overwrite with conditional-get does allow clobber when the file at the URL is newer:
aria2c http://www.skype.com/go/getskype-msi --allow-overwrite=true --conditional-get=true

But it still doesn't output the local filename that was used. Is there a way to get the log or output table to display this somehow?
no-filename

@tatsuhiro-t
Copy link
Collaborator

I'm ok to add NOTICE level logging for file name.
The above image looks a bit strange, since file name is missing after "Downlaod has already completed:" and "Download complete:".

@tatsuhiro-t tatsuhiro-t added this to the v1.28.0 milestone Sep 16, 2016
@tatsuhiro-t
Copy link
Collaborator

It looks like a bug that file name is missing in these logs.

@tatsuhiro-t
Copy link
Collaborator

Fix committed via a31e73d

@tatsuhiro-t
Copy link
Collaborator

I was a bit confused, but I think the above commit fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants