Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet Explorer 8 & 9-beta DOES NOT WORK #23

Closed
zd-dalibor opened this issue Oct 26, 2010 · 6 comments
Closed

Internet Explorer 8 & 9-beta DOES NOT WORK #23

zd-dalibor opened this issue Oct 26, 2010 · 6 comments

Comments

@zd-dalibor
Copy link

Mootools Datepocker do not work in this two browsers.
It seems like work, bur after two or three times datepicker opens I get this error:


Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; .NET4.0C; .NET4.0E)
Timestamp: Tue, 26 Oct 2010 13:12:24 UTC

Message: Object doesn't support this property or method
Line: 328
Char: 37
Code: 0

URI: /datepicker.js

@roosten
Copy link

roosten commented Oct 29, 2010

I'll try to be a bit contructive here:

I assigned DatePicker to all inputs like this:
new DatePicker($$('input.date'))

The first time I click on the input it works fine.
The close event (line 327) is called twice though on closing.

The second time the datepicker opens but yields an error on closing becouse frame.destroy==undefined.

I hope this helps somewhat.

p.s.
I have no choice but to use IE8 :(

@goulian
Copy link

goulian commented Oct 29, 2010

Hi roosten, here is what I did, at Line 328 I replaced frame.destroy() with Browser.ie ? frame.empty().dispose() : frame.destroy()

@eerne
Copy link

eerne commented Oct 29, 2010

Would be great if you provide a jsfiddle example next time, to reproduce the issue. I've set up a basic datepicker on http://jsfiddle.net/tofu/NABTC/

Does that work for you or give error?

Also: do you guys use iframeshim?

@goulian
Copy link

goulian commented Oct 29, 2010

Does that work for you or give error?
hi eerne, just checked your jsfiddle example and yes error reproduced in ie8, please see issue No.7 that I commented:
http://github.com/arian/mootools-datepicker/issues#issue/24

Also: do you guys use iframeshim? No

thanks for all your work...

@roosten
Copy link

roosten commented Nov 1, 2010

Thanks goullian,

Your fix works for me as well and I guess this works similar to destroy(). At least doesn't leave unused objects.

Hi, eerne, your example produced the exact same error in ie8.
I'm not using iframeshim unless it's default.

@arian
Copy link
Owner

arian commented Nov 5, 2010

Thanks goulian. This error is fixed in 1096e9596

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants