deep sea fisherman achievement might not be working

[bleutailfly]

🐞 Describe the bug

[10:18] kraken
[10:18] Information about kraken will cost 8295. Would you like to pay?
[10:18] yes
[10:18] Thank you.
[10:18] Lovena puts her hand on the bestiary and stares into crystal ball.
[10:19] bleutailfly, you have killed a total of 74 krakens. You have killed 71 alone and 3 in a group.
[10:19] read
[10:19] I see you are carrying a bestiary. Which enemy would you like information about?
[10:19] shark
[10:19] Information about shark will cost 6555. Would you like to pay?
[10:19] yes
[10:19] Thank you.
[10:19] Lovena puts her hand on the bestiary and stares into crystal ball.
[10:19] bleutailfly, you have killed a total of 432 sharks. You have killed 429 alone and 3 in a group.
[10:19] Come back soon bleutailfly.
[10:20] hi
[10:20] Welcome to my psychic parlor. How can I help you?
[10:20] read
[10:20] I see you are carrying a bestiary. Which enemy would you like information about?
[10:20] neo kraken
[10:20] Information about neo kraken will cost 8670. Would you like to pay?
[10:20] yes
[10:20] Thank you.
[10:20] Lovena puts her hand on the bestiary and stares into crystal ball.
[10:20] bleutailfly, you have killed a total of 48 neo krakens. You have killed 46 alone and 2 in a group.
[10:21] Come back soon bleutailfly.
A clear description of the issue.

🔥 How to reproduce

Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. See error

🌍 Environment

• Java client
• Web client

Location in game: ...

deniran psychic parlor , interior

🛠️ Suggested fixes

Ideas on how to fix the problem: ...

beats me

🔭 Additional information

that is over the 500 fish that is needed for the quest
Anything else

[AntumDeluge]

It looks like the problem is that the achievement is using PlayerHasKilledNumberOfCreaturesCondition, which is used for requiring a kill count for each creature listed. So it only registers if you have killed 500 sharks, 500 kraken, & 500 neo kraken. Should be modified to use a custom condition or add a combined flag in PlayerHasKilledNumberOfCreaturesCondition.java.

Edit: Zombie Apocalypse can be used as an example of how to implement it. JUnit test will probably need updated as well.

[nhnb]

We should also change the description of the achievement to either say "Kill 500 sharks, kraken and neo kraken each" or "Kill 500 deep sea creatures"

[AntumDeluge]

@nhnb Oh wait, if that is the description, then the achievement is working as intended (it's been a while since I played). So nothing should be changed.

[AntumDeluge]

Sorry, I spoke before thinking. The description is currently "Kill 500 sharks, kraken, & neo kraken". From the look of the code, it seems the original intention is to kill 500 each. So ya, should probably be changed to say "each".

[AntumDeluge]

Description clarified: 65d68b3