Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The escape key triggered from anywhere closes any modal dialog #1594

Open
ymeine opened this issue Feb 15, 2016 · 0 comments
Open

The escape key triggered from anywhere closes any modal dialog #1594

ymeine opened this issue Feb 15, 2016 · 0 comments

Comments

@ymeine
Copy link
Contributor

ymeine commented Feb 15, 2016

When a modal dialog is opened, pressing the escape key closes it.

However, the user would expect this to be true only if the focus is set inside the area covered by the modal dialog, which comprises the dialog itself plus its mask, that is the whole container of the modal dialog.

The issue is that currently it is not the case, the events are listened on the body no matter what is the actual container of the dialog, making it possible to close a modal dialog inside a container where the focus is not currently in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant