Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] uYouPlus’ “Hide channel watermark” doesn’t do anything #198

Closed
2 tasks done
Cactism opened this issue Nov 11, 2023 · 15 comments
Closed
2 tasks done

[Bug] uYouPlus’ “Hide channel watermark” doesn’t do anything #198

Cactism opened this issue Nov 11, 2023 · 15 comments
Labels
bug Something isn't working

Comments

@Cactism
Copy link

Cactism commented Nov 11, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Have you read the FAQ?

  • Yes, I did read the FAQ

Device info

  • iOS/iPadOS version: iOS 15.7.1
  • Device model: iPhone 13
  • Sideload tool (AltStore, Sideloadly, TrollStore,...): Sideloadly
  • The specific version of uYouPlusExtra (latest or newest is NOT a version number!): v18.44.3-3.0.1-F2

Describe the bug

The setting which should “Hide channel watermark[s]” under uYouPlus’ settings doesn’t appear to be working. This setting worked in the original uYouPlus’ .ipa compiled by qnblackhat (v18.14.1-3.0), but not in uYouPlusExtra’s latest release (v18.44.3-3.0.1-F2).

4ECB7F7F-672A-4B05-8473-A424BF541696
89F8D99E-3E26-4EF1-AD87-7467D21BC4CD

Steps to reproduce the issue

  1. Open the YouTube in-app’s settings.
  2. Navigate to uYouPlus
  3. Navigate to Video Controls Overlay Options
  4. Turn on the Hide channel watermark setting
  5. Restart the YouTube app
  6. Open a video from a channel that has a channel watermark (e.g. Storyline EP "La vaguelette" MV | Genshin Impact)
  7. View the video in full screen
  8. Channel watermark is still there.

Video demonstration: https://www.youtube.com/watch?v=IWUSgtqwcec

Crash log (if the app crashes)

App does not crash

Are you using the newest version of uYouPlus? If not, why?

✅ Yes, I'm using the latest version of uYouPlus right now

Does the issue happen with the official YouTube from AppStore?

❌ No, I can't reproduce this issue in the official YouTube from AppStore

Additional context

No response

@Cactism Cactism added the bug Something isn't working label Nov 11, 2023
@arichornlover
Copy link
Owner

YouTube changed the watermark stuff I think, I’ll check it out and see if I can resolve it

@Cactism Cactism changed the title [Bug] uYouPlus’ “Hide Channel Watermark” doesn’t do anything [Bug] uYouPlus’ “Hide channel watermark” doesn’t do anything Nov 11, 2023
@Shaukariya
Copy link

Yh same

@Cactism Cactism closed this as completed Nov 16, 2023
@Cactism
Copy link
Author

Cactism commented Nov 16, 2023

Fixed as of latest release.

@arichornlover
Copy link
Owner

seems like my fix worked. 👍

@Cactism
Copy link
Author

Cactism commented Nov 16, 2023

seems like my fix worked. 👍

wait nevermind — while yes, the watermark does disappear after you click on a video from a channel that has a channel watermark, it would reappear once you open the video controls by tapping.

RPReplay_Final1700095785.mov

@Cactism Cactism reopened this Nov 16, 2023
@arichornlover
Copy link
Owner

arichornlover commented Nov 16, 2023

Alright that wasn’t supposed to happen but at least the Hide Watermark is working on some areas of the app though. I’ll also check out on why it’s doing this?

@Cactism
Copy link
Author

Cactism commented Nov 16, 2023

Sounds great! Thanks for spending your time fixing this issue despite this being a minor bug 💖

@arichornlover
Copy link
Owner

I updated it in the latest release v18.46.3-3.0.1 but can’t confirm if it fixes the problem.

@Cactism
Copy link
Author

Cactism commented Nov 21, 2023

I updated it in the latest release v18.46.3-3.0.1 but can’t confirm if it fixes the problem.

Just installed the new release, and unfortunately the problem still persists 🥲

FullSizeRender.MOV

@arichornlover
Copy link
Owner

arichornlover commented Dec 2, 2023

https://github.com/arichorn/uYouPlusExtra/releases/tag/v18.46.3-3.0.1-F2
Alright I changed the functionality completely, now instead it will remove the video player watermark in a different way

@arichornlover
Copy link
Owner

Hey! I tested it out and it works! But for some odd reason, it also removed the video player overlay that allows you to be able to tap or interact with the video player. I’m starting to think any possible fix I find just fails.

@Cactism
Copy link
Author

Cactism commented Dec 4, 2023

Hey! I tested it out and it works! But for some odd reason, it also removed the video player overlay that allows you to be able to tap or interact with the video player. I’m starting to think any possible fix I find just fails.

Thank you for updating us on the development journey 🥺❤️

@arichornlover
Copy link
Owner

Hey! I tested it out and it works! But for some odd reason, it also removed the video player overlay that allows you to be able to tap or interact with the video player. I’m starting to think any possible fix I find just fails.

Thank you for updating us on the development journey 🥺❤️

no problem, just watch out because you might have #238

@reticivis-net
Copy link

Can still repro this issue on the latest version
IMG_9656

@arichornlover
Copy link
Owner

That’s because I reverted the changes in the latest release to get rid of #238

@Cactism Cactism closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants