Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Disable Pinch to Zoom is interfering with DontEatMyContent #206

Open
2 tasks done
Blarnix opened this issue Nov 15, 2023 · 5 comments
Open
2 tasks done

[Bug] Disable Pinch to Zoom is interfering with DontEatMyContent #206

Blarnix opened this issue Nov 15, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@Blarnix
Copy link

Blarnix commented Nov 15, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Have you read the FAQ?

  • Yes, I did read the FAQ

Device info

  • iOS/iPadOS version: iOS 17.1.1
  • Device model: iPhone 14 Pro Max
  • Sideload tool (AltStore, Sideloadly, TrollStore,...): AltStore
  • The specific version of uYouPlus (latest or newest is NOT a version number!): 18.44.3-3.0.1

Describe the bug

Hi, I'm having some issues in regards to DontEatMyContent and Disable Pinch to Zoom being enabled at the same time. Having both of these running at once leads to this strange behavior:
https://user-images.githubusercontent.com/61402697/282995841-e3a19b8e-5dee-4ce9-bc5e-4186752f6878.MOV

I'm not sure if it's on one side or the other, so I reported the issue to both repos. This has been going on for quite a while, so it's not really anything new. Hopefully it's an easy fix.
Thanks.

Steps to reproduce the issue

  1. Open uYouPlus+
  2. Enable DontEatMyContent and "Disable Pinch to Zoom"
  3. Restart uYouPlus+
  4. Open a video with a wide aspect ratio (I suggest LTT or MKBHD)
  5. Try to pinch to enter full screen or pinch out.

Crash log (if the app crashes)

No response

Are you using the newest version of uYouPlus? If not, why?

✅ Yes, I'm using the latest version of uYouPlus right now

Does the issue happen with the official YouTube from AppStore?

❌ No, I can't reproduce this issue in the official YouTube from AppStore

Additional context

No response

@Blarnix Blarnix added the bug Something isn't working label Nov 15, 2023
@Blarnix
Copy link
Author

Blarnix commented Nov 15, 2023

Seems that the issue will be fixed once a new .deb is released for DontEatMyContent, according to therealFoxter.

Thanks! I think they nuked the pinch recognizer which I'm using to deactivate the constraints when you pinch to zoom. a08f9d9 should fix this.

Originally posted by @therealFoxster in therealFoxster/DontEatMyContent#15 (comment)

@arichornlover
Copy link
Owner

arichornlover commented Nov 16, 2023

This should work with the latest release of uYouPlusExtra aswell.

@Blarnix
Copy link
Author

Blarnix commented Nov 16, 2023

Unfortunately, the issue is still present.

@arichornlover
Copy link
Owner

arichornlover commented Nov 16, 2023

That’s odd.. it’s using DontEatMyContent v1.0.12?

@Blarnix
Copy link
Author

Blarnix commented Nov 16, 2023

That’s odd.. it’s using DontEatMyContent v1.0.12?

I think so? I'm not sure how to check the specific version of DontEatMyContent, but I am using UYouPlus+ 18.45.2-3.0.1 that was just released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants