Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constant evaluation based on coordinates and timezone #195

Merged
merged 10 commits into from Oct 29, 2022
Merged

Constant evaluation based on coordinates and timezone #195

merged 10 commits into from Oct 29, 2022

Conversation

Inf-inity
Copy link
Collaborator

@Inf-inity Inf-inity commented Oct 27, 2022 •
edited

Description about the changes

  • added formula for calculating sunrise / sunset for given coordinates
  • added option to parse function for setting coordinates, overwriting the timezone given, calculating its own, using the timezonefinder module
  • made sunrise and sunset enums independent
  • added Result object

Testcases that have been added

  • next constant: None

Constants that have been added

  • constant: datetime(...)

Python Version you tested this feature on

  • Python 3.7
  • Python 3.8
  • Python 3.9
  • Python 3.10
  • Python 3.11

@Inf-inity Inf-inity changed the title [Do not merge!] Feature/suntime Feature/suntime Oct 27, 2022
Ari24-cb24
Ari24-cb24 requested changes Oct 28, 2022
View reviewed changes
datetimeparser/evaluator/evaluatormethods.py Outdated Show resolved Hide resolved
datetimeparser/evaluator/evaluatormethods.py Outdated Show resolved Hide resolved
datetimeparser/utils/models.py Outdated Show resolved Hide resolved
datetimeparser/utils/models.py Show resolved Hide resolved
@Ari24-cb24
Copy link
Member

Außerdem, fix deine PR Titel

@Ari24-cb24 Ari24-cb24 changed the title Feature/suntime Constant evaluation based on coordinates and timezone Oct 28, 2022
@Ari24-cb24 Ari24-cb24 added the evaluator Used for any kinds of issues with the evaluator label Oct 28, 2022
Ari24-cb24
Ari24-cb24 requested changes Oct 29, 2022
View reviewed changes
Copy link
Member

@Ari24-cb24 Ari24-cb24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change Readme

README.md Outdated Show resolved Hide resolved
@Inf-inity Inf-inity merged commit 7ee7c1c into dev Oct 29, 2022
@Inf-inity Inf-inity deleted the feature/suntime branch October 29, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ari24-cb24 Ari24-cb24 Ari24-cb24 approved these changes

Assignees
No one assigned
Labels
evaluator Used for any kinds of issues with the evaluator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Inf-inity @Ari24-cb24