Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more Eventes #26

Closed
5 of 8 tasks
leon-3 opened this issue Nov 16, 2021 · 3 comments · Fixed by #28 or #30
Closed
5 of 8 tasks

Add more Eventes #26

leon-3 opened this issue Nov 16, 2021 · 3 comments · Fixed by #28 or #30
Assignees
@Ari24-cb24 @Inf-inity
Labels
new constant/event For Constants or Events
Milestone
Production Ready

Comments

@leon-3
Copy link

leon-3 commented Nov 16, 2021 •
edited by Ari24-cb24

Here are some ideas for events to add

  • Beginning of Advent of Code
  • End of Advent of Code
  • Beginning/End of Summer/Spring/Fall/Winter
  • April Fool's Day
  • Thanksgiving
  • (Independence Day)
  • Black Friday
  • Cyber Monday
@Ari24-cb24 Ari24-cb24 added the new constant/event For Constants or Events label Nov 16, 2021
@Ari24-cb24
Copy link
Member

I don't think Black Friday and Cyber Monday is a good idea

@Ari24-cb24 Ari24-cb24 linked a pull request Nov 16, 2021 that will close this issue
Enumeinträge für Issue 26 hinzugefügt: #28
Merged
@Ari24-cb24 Ari24-cb24 reopened this Nov 16, 2021
@Ari24-cb24
Copy link
Member

still things missing so remember to reopen on merged prs

@Ari24-cb24 Ari24-cb24 linked a pull request Nov 17, 2021 that will close this issue
Fixed Parser errors and added new constants + testcases #30
Merged
@Ari24-cb24
Copy link
Member

I still dont know about independence day tho. Open to discuss but open a new issue please

@Ari24-cb24 Ari24-cb24 added this to the Production Ready milestone Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ari24-cb24 Ari24-cb24

@Inf-inity Inf-inity

Labels
new constant/event For Constants or Events
Projects
None yet
Milestone
Production Ready
3 participants
@Ari24-cb24 @leon-3 @Inf-inity