Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[General Issue] Throw custom exceptions instead of returning None #99

Open
Ari24-cb24 opened this issue Feb 17, 2022 · 0 comments
Open

[General Issue] Throw custom exceptions instead of returning None #99

Ari24-cb24 opened this issue Feb 17, 2022 · 0 comments
Assignees
@Ari24-cb24 @Inf-inity
Labels
evaluator Used for any kinds of issues with the evaluator parser Used for any kinds of issues with the parser

Comments

@Ari24-cb24
Copy link
Member

Describe your issue here

If the user input is not correct, datetimeparser returns None. As we want to provide more information about what was wrong, we're going to throw custom exceptions whenever we would normally return None.
@Ari24-cb24 Ari24-cb24 added parser Used for any kinds of issues with the parser evaluator Used for any kinds of issues with the evaluator labels Feb 17, 2022
@Ari24-cb24 Ari24-cb24 added this to the Production Ready milestone Feb 17, 2022
@Ari24-cb24 Ari24-cb24 removed this from the Production Ready milestone Mar 25, 2022
@Ari24-cb24 Ari24-cb24 added this to the Production Ready milestone Jun 5, 2022
@Ari24-cb24 Ari24-cb24 removed this from the Production Ready milestone Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ari24-cb24 Ari24-cb24

@Inf-inity Inf-inity

Labels
evaluator Used for any kinds of issues with the evaluator parser Used for any kinds of issues with the parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ari24-cb24 @Inf-inity