Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI class diagram errors #19

Open
Arif-Khalid opened this issue Apr 14, 2023 · 1 comment
Open

UI class diagram errors #19

Arif-Khalid opened this issue Apr 14, 2023 · 1 comment

Comments

@Arif-Khalid
Copy link
Owner

Arif-Khalid commented Apr 14, 2023

UML is labelled abstract but is not abstract. In addition, the static methods in UI are not underlined in the class diagram. This could lead to serious misunderstanding for new developers.
image.png

@nus-pe-script
Copy link

nus-pe-script commented Apr 18, 2023

Team's Response

Thanks for pointing that out. I did not double check the class diagram with the code. But I don't think the severity would be high, because the IDE will catch that we are instantiating an abstract class and point us the error. Which can be easily changed.

Items for the Tester to Verify

❓ Issue severity

Team chose [severity.Low]
Originally [severity.High]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants