Skip to content
This repository has been archived by the owner on Sep 9, 2023. It is now read-only.

Things to consider #1

Closed
saaiful opened this issue Jan 18, 2022 · 6 comments
Closed

Things to consider #1

saaiful opened this issue Jan 18, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@saaiful
Copy link

saaiful commented Jan 18, 2022

  1. Most courier has there own location list (and it's based on location id), you can add option to grab that list.
  2. They also have package option adding that is a good idea.
@saaiful
Copy link
Author

saaiful commented Jan 18, 2022

eCourier_Merchant_API_Document_General_v5.1
2.3 - 2.10

@arif98741
Copy link
Owner

arif98741 commented Jan 18, 2022

Thanks for mentioning the point.

I want share you that, both options that you have mentioned are already exist in this package.
User will have to run below code for accessing data using

/packages 
/branches
/thana
/area 
/thana-list


$courier = Courier::getInstance();
$courier->setProvider(ECourier::class,'production');
$courier->setConfig([
	'API-KEY' => 'XXX',
	'API-SECRET' => 'XXX',
	'USER-ID' => 'XXXX',
]);
$courier->setRequestEndpoint('area-list', ['postcode' => '1212']);
$response = $courier->send();
echo $response->getData();

etc
endpoints

@arif98741 arif98741 added the enhancement New feature or request label Jan 18, 2022
@saaiful
Copy link
Author

saaiful commented Jan 18, 2022

Your supported courier is just a API accessor, but when your package support 10/20 API it is not a good idea to send developer to read API docs for those courier.

What is the benefit of having all courier in one package when you have to read documentation for all of them.

@saaiful
Copy link
Author

saaiful commented Jan 18, 2022

Courier provider methods to be implemented:

  1. Ping (to test service availability, not required)
  2. PackageList (required)
  3. BookParcel (required)
  4. CheckStatus (required)
  5. LocationList (complicated)
  6. PrintLabel (if possible)

Just Basic Idea.

@arif98741
Copy link
Owner

Thanks for suggestions. I will try to add those feature

@arif98741
Copy link
Owner

Courier provider methods to be implemented:

  1. Ping (to test service availability, not required)
  2. PackageList (required)
  3. BookParcel (required)
  4. CheckStatus (required)
  5. LocationList (complicated)
  6. PrintLabel (if possible)

Just Basic Idea.

several methods according to your suggession are integrated in this package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants