Ensure the permissions of a new redis-sentinel.conf #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without these changes a from-scratch redis-sentinel.conf can be created that is not writable by the redis user, as such the sentinel server will exit immediately after starting. This change ensures the permissions of the *.puppet file and then preserves those permissions upon copy. Unfortunately the copied-to file is hard to test in the spec files, so verification in test is no longer available. It works properly in manual testing.
|
Sorry I didn't realize this in the original pull request @arioch. I guess all my testing was on existing installations. The bug will rarely show up since the distros install a default file in the first place, but in case it has been removed, this is useful to have (it bit me during packstack testing). |
|
Not to worry. 👍 |
arioch
added a commit
that referenced
this pull request
Jan 6, 2015
Ensure the permissions of a new redis-sentinel.conf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these changes a from-scratch redis-sentinel.conf can be
created that is not writable by the redis user, as such the sentinel
server will exit immediately after starting.
This change ensures the permissions of the *.puppet file and then
preserves those permissions upon copy. Unfortunately the copied-to
file is hard to test in the spec files, so verification in test is
no longer available. It works properly in manual testing.