Add 2.4.10 config file for CentOS 6 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petems
force-pushed
the
add_2410_config_file
branch
4 times, most recently
from
9f5b487
to
cb2152d
Compare
petems
force-pushed
the
add_2410_config_file
branch
3 times, most recently
from
f55ecf7
to
4f12494
Compare
* Redis 2.4.10 is old in software terms (2014) * Redis will refuse to start * The amount of logic that would have to be added to the template to isolate new config values would be hard to maintain * For now, lets just have a CentOS 6 specific erb * Adds spec to check also * Changes acceptance test for sentinel to not run on CentOS 6 * Adds function for Puppet 3/4 compatibility with the fact
petems
force-pushed
the
add_2410_config_file
branch
from
4f12494
to
192ea12
Compare
cegeka-jenkins
pushed a commit
to cegeka/puppet-redis
that referenced
this pull request
Feb 16, 2021
* Redis 2.4.10 is old in software terms (2014) * Redis will refuse to start * The amount of logic that would have to be added to the template to isolate new config values would be hard to maintain * For now, lets just have a CentOS 6 specific erb * Adds spec to check also * Changes acceptance test for sentinel to not run on CentOS 6 * Adds function for Puppet 3/4 compatibility with the fact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to the template to isolate new config values would
be hard to maintain
run on CentOS 6