Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to configure Unix socket binding #97

Merged
merged 2 commits into from Jun 17, 2016

Conversation

gcelestine
Copy link
Contributor

No description provided.

@@ -573,6 +583,8 @@
$tcp_backlog = $::redis::params::tcp_backlog,
$tcp_keepalive = $::redis::params::tcp_keepalive,
$timeout = $::redis::params::timeout,
$unixsocket = $::redis::unixsocket,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you forget the ::params prefix on the both parameters default values.
This may be the reason why CI fail with Puppet >= 4.0

@gcelestine can you fix this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue fixed and all tests passed succesfully

@petems
Copy link
Member

petems commented Jun 17, 2016

@gcelestine Was just about to implement this, so here's some specs you can add for test coverage 😄

  describe 'with parameter unixsocket' do
    let (:params) {
      {
        :unixsocket => '/tmp/redis.sock'
      }
    }

    it { should contain_file('/etc/redis/redis.conf.puppet').with(
        'content' => /unixsocket.*\/tmp\/redis.sock/
      )
    }
  end

  describe 'with parameter unixsocketperm' do
    let (:params) {
      {
        :unixsocketperm => '777'
      }
    }

    it { should contain_file('/etc/redis/redis.conf.puppet').with(
        'content' => /unixsocketperm.*777/
      )
    }
  end

@petems
Copy link
Member

petems commented Jun 17, 2016

@arioch can we get a merge on this? Need it for a project I'm doing 😸

@arioch
Copy link
Contributor

arioch commented Jun 17, 2016

@gcelestine my apologies for the long wait. Excellent stuff. 👍
@petems If you agree to send me a PR with your test coverage. 😉

@arioch arioch merged commit 6db9f41 into voxpupuli:master Jun 17, 2016
@petems petems mentioned this pull request Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants