Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting a vulnerability #22

Closed
igibek opened this issue Apr 10, 2023 · 4 comments
Closed

Reporting a vulnerability #22

igibek opened this issue Apr 10, 2023 · 4 comments

Comments

@igibek
Copy link

igibek commented Apr 10, 2023

Hello!

I hope you are doing well!

We are a security research team. Our tool automatically detected a vulnerability in this repository. We want to disclose it responsibly. GitHub has a feature called Private vulnerability reporting, which enables security research to privately disclose a vulnerability. Unfortunately, it is not enabled for this repository.

Can you enable it, so that we can report it?

Thanks in advance!

PS: you can read about how to enable private vulnerability reporting here: https://docs.github.com/en/code-security/security-advisories/repository-security-advisories/configuring-private-vulnerability-reporting-for-a-repository

@github-actions
Copy link

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

@github-actions github-actions bot added the stale label Jun 10, 2023
@shirk3ysiili
Copy link

@igibek Hello!
Can you please share more details about this vulnerability? We plan to use this library in our project, so we want to make sure it doesn't contain any major security bugs.

Thanks in advance!

@github-actions github-actions bot removed the stale label Jun 14, 2023
@aripalo
Copy link
Owner

aripalo commented Aug 2, 2023

@igibek the private vulnerability reporting has now been enabled.

@shirk3ysiili I'm pretty sure that the vulnerability is one of the dependency vulnerabilities found also by DependaBot alerts (as often these kinds of issues are opened automatically by security research companies when they run security analysis tools that can be compared to DependaBot). Unfortunately I've missed those as DependaBot PRs haven't been enabled for some reason (they were previously, not sure what happened, maybe I've accidentally disabled those)

  • At really quick glance it seems the vulnerabilities seem not to affect the deployed configurations any way, but instead require that some untrusted code would be calling the affected dependencies of this construct (which shouldn't be the case when you're running CDK in a trusted environment)
  • That being said, I'll patch these soon: Patch vulnerable dependencies #25

@aripalo
Copy link
Owner

aripalo commented Aug 2, 2023

I'm closing this issue as the original issue (enabling private vuln reporting) is done and also the current vulns are now patched via #28

@aripalo aripalo closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants