Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta.tests): add anta_test decorator #123

Merged
merged 6 commits into from
Dec 14, 2022

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Sep 20, 2022

No description provided.

@titom73
Copy link
Collaborator

titom73 commented Oct 18, 2022

Looks good to me! It makes test function much easier to build

Need to be merged after a sprint to convert all existing tests to this new syntax

Also, we need to update documentation:

  • Docstring for the decorator
  • Markdown about how to build a test function.

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@gmuloc
Copy link
Collaborator Author

gmuloc commented Nov 15, 2022

@titom73 / @mtache - this PR may be a bit black magic for users - the decorator is injecting the Result object and so you can call the test function without the TestResult argument.
It may be better to have the result object as an "optional" keyword argument injected by the decorator so it does not seem too voodoo.

or maybe another solution?

Thoughts ?

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@mtache mtache self-requested a review December 14, 2022 14:46
@mtache
Copy link
Collaborator

mtache commented Dec 14, 2022

Ship it !

@mtache mtache merged commit 5b16412 into aristanetworks:master Dec 14, 2022
@titom73 titom73 changed the title Feat: add anta_test decorator feat(anta.tests): add anta_test decorator Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants