Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta): update scripts #127

Merged
merged 24 commits into from
Jan 10, 2023
Merged

feat(anta): update scripts #127

merged 24 commits into from
Jan 10, 2023

Conversation

mtache
Copy link
Collaborator

@mtache mtache commented Jan 6, 2023

Update scripts to work with the new ANTA asyncio framework.

gmuloc
gmuloc reviewed Jan 6, 2023
View reviewed changes
anta/inventory/__init__.py Outdated Show resolved Hide resolved
anta/inventory/__init__.py Outdated Show resolved Hide resolved
anta/runner.py Show resolved Hide resolved
scripts/clear-counters.py Outdated Show resolved Hide resolved
mtache and others added 18 commits January 10, 2023 12:43
@mtache
refactor: clean shebangs
8556f1f
@mtache
refactor(anta): improve logs during device connection
8baa95a
@mtache
refactor(scripts): use asyncio in collect-eos-commands.py
4386e3c
@mtache
refactor(scripts): clean clear-counters.py
25df9fb
@mtache
refactor(scripts): use asyncio in evpn-blacklist-recovery.py
9c9cac9
@mtache
refactor(scripts): improve logs in create-devices-inventory-from-cvp.py
efd608e
@mtache
refactor(anta): improve logs
fbc63ea
@mtache
clean: remove dependencies
45cd5d1
@mtache
scripts: improved logs
a8f8645
@mtache @gmuloc
Update anta/inventory/__init__.py
035d450 
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@mtache @gmuloc
Update anta/inventory/__init__.py
752602a 
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@mtache
fix: implemented comments
0b74ba5
@mtache
lint: fix pylint errors
b654d44
@mtache
pytest: update tests
f257be3
@mtache
nice typo
b87415a
@mtache
fix linting errors
5a3f8d5
@mtache
Make Sure You Are Square With Your God Before Trying To Merge This
7610f06
@mtache
TODO: Fix later
5bfc3f0
@mtache mtache removed the request for review from titom73 January 10, 2023 16:48
@mtache mtache removed the request for review from ksator January 10, 2023 16:48
gmuloc
gmuloc approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look Mostly Good To Me

(maybe some doc need to be fixed further)

@mtache mtache merged commit 630bff2 into aristanetworks:master Jan 10, 2023
@mtache mtache deleted the asyncio-scripts branch January 10, 2023 16:48
@titom73 titom73 mentioned this pull request Jan 11, 2023
Closed
@titom73 titom73 changed the title feat(asyncio): update scripts feat(anta): update scripts Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

Assignees

@mtache mtache

Labels
rn: feat(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mtache @gmuloc