Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add Sflow config for ethernet and port_channel interfaces #1805

Merged
merged 7 commits into from
Feb 15, 2023
Merged

Feat(eos_cli_config_gen): Add Sflow config for ethernet and port_channel interfaces #1805

merged 7 commits into from
Feb 15, 2023

Conversation

UchihaItachiSama
Copy link
Contributor

Change Summary

Add sflow configuration for ethernet_interfaces and port_channel_interfaces

Related Issue(s)

Fixes #1757

Component(s) name

arista.avd.eos_cli_config_gen
ethernet_interfaces
port_channel_interfaces

Proposed changes

CLI commands:

sflow enable
sflow egress enable
sflow egress unmodified enable

https://www.arista.com/en/support/toi/eos-4-24-2f/14579-support-for-software-egress-sflow
https://www.arista.com/en/support/toi/eos-4-25-1f/14637-egress-sflow

data model:

sflow:
    enabled: < true | false >
    egress:
        enabled: < true | false >
        unmodified_enabled: < true | false >

How to test

Ran molecule test --scenario-name eos_cli_config_gen
make refresh-facts

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@UchihaItachiSama UchihaItachiSama requested a review from a team as a code owner May 19, 2022 18:06
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels May 19, 2022
@UchihaItachiSama UchihaItachiSama force-pushed the eos_cli_config_gen-add-sflow-config-support-ethernet-port-channel-interfaces branch from 0ea04cd to f7c0a63 Compare May 20, 2022 17:06
ClausHolbechArista
ClausHolbechArista requested changes May 23, 2022
View reviewed changes
..._collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/sflow-interfaces.j2 Outdated Show resolved Hide resolved
..._collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/sflow-interfaces.j2 Outdated Show resolved Hide resolved
..._collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/sflow-interfaces.j2 Outdated Show resolved Hide resolved
..._collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/sflow-interfaces.j2 Outdated Show resolved Hide resolved
..._collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/sflow-interfaces.j2 Outdated Show resolved Hide resolved
..._collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/sflow-interfaces.j2 Outdated Show resolved Hide resolved
..._collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/sflow-interfaces.j2 Outdated Show resolved Hide resolved
..._collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/sflow-interfaces.j2 Outdated Show resolved Hide resolved
..._collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/sflow-interfaces.j2 Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/ethernet-interfaces.j2 Outdated Show resolved Hide resolved
@ClausHolbechArista
Copy link
Contributor

Moving to draft until review comments has been addressed. Click "ready for review" when you have updated.

@ClausHolbechArista ClausHolbechArista marked this pull request as draft June 10, 2022 12:41
@github-actions github-actions bot added the state: conflict PR with conflict label Jun 21, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 15 days

@UchihaItachiSama UchihaItachiSama force-pushed the eos_cli_config_gen-add-sflow-config-support-ethernet-port-channel-interfaces branch from 58da529 to 7c50686 Compare February 3, 2023 06:59
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@UchihaItachiSama UchihaItachiSama marked this pull request as ready for review February 3, 2023 07:26
@ClausHolbechArista
Copy link
Contributor

Please add a comment or resolve the review comments you have addressed.

@UchihaItachiSama
Copy link
Contributor Author

Please add a comment or resolve the review comments you have addressed.

Ack, resolved and added comments for the requested changes.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

ClausHolbechArista
ClausHolbechArista approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista requested a review from a team February 15, 2023 07:33
gmuloc
gmuloc approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista force-pushed the eos_cli_config_gen-add-sflow-config-support-ethernet-port-channel-interfaces branch from 7c50686 to a9bca70 Compare February 15, 2023 09:04
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 15, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista merged commit 7d1f3b8 into aristanetworks:devel Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@tgodaA tgodaA Awaiting requested review from tgodaA

@xaviramon xaviramon Awaiting requested review from xaviramon

Assignees

@UchihaItachiSama UchihaItachiSama

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Add sflow to interfaces
5 participants
@UchihaItachiSama @ClausHolbechArista @gmuloc @xaviramon @tgodaA