Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): igmp querier in network services #1958

Merged
merged 8 commits into from Jul 28, 2022
Merged

Feat(eos_designs): igmp querier in network services #1958

merged 8 commits into from Jul 28, 2022

Conversation

carlbuchmann
Copy link
Member

@carlbuchmann carlbuchmann commented Jul 22, 2022 •
edited

Change Summary

Provide knob in networks services to configure igmp querier at tenant,SVI and l2vlan.

Component(s) name

arista.avd.eos_designs

Proposed changes

< network_services_keys.key_1 >:
  < tenant_a >:
    # Enable igmp snooping querier for each SVI/l2vlan x within tenant, by default using IP address of Loopback 0.
    igmp_snooping_querier:
       enabled: < true | false >
       source_address: < ipv4_address -> default ip address of Loopback0 >
       version: < 1, 2, 3 -> default 2 (EOS) >
    vrfs:
      < vrf_name >:
        svis:
            # Enable igmp snooping querier, by default using IP address of Loopback 0.
            igmp_snooping_querier:
              enabled: < true | false >
              source_address: < ipv4_address -> default ip address of Loopback0 >
              version: < 1, 2, 3 -> default 2 (EOS) >
    l2vlans:
      < vlan_id >:
        # Enable igmp snooping querier, by default using IP address of Loopback 0.
        igmp_snooping_querier:
          enabled: < true | false >
          source_address: < ipv4_address -> default ip address of Loopback0 >
          version: < 1, 2, 3 -> default 2 (EOS) >

How to test

See Molecule test case

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@carlbuchmann carlbuchmann requested a review from a team as a code owner July 22, 2022 16:00
@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Jul 22, 2022
@carlbuchmann carlbuchmann added this to In progress in CA-PROJECT-03 via automation Jul 22, 2022
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jul 22, 2022
@carlbuchmann carlbuchmann force-pushed the feature-eos-designs-igmp-querier branch from 60d7b3f to d3fb440 Compare July 22, 2022 16:02
@carlbuchmann carlbuchmann marked this pull request as draft July 25, 2022 17:56
@carlbuchmann carlbuchmann marked this pull request as ready for review July 27, 2022 14:53
@carlbuchmann carlbuchmann force-pushed the feature-eos-designs-igmp-querier branch from 06d443e to c9b38c6 Compare July 27, 2022 14:53
@carlbuchmann carlbuchmann requested a review from tgodaA July 27, 2022 18:05
@carlbuchmann
svi_igmp_snooping_enabled
939ee9d 
is protected by arista.avd.default
@carlbuchmann carlbuchmann requested a review from tgodaA July 28, 2022 14:55
@carlbuchmann
igmp_snooping_querier_version
8b0bde9 
is protected by arista.avd.default
tgodaA
tgodaA approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

philippebureau
philippebureau approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@philippebureau philippebureau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outputs as expected
doc is clear

@carlbuchmann carlbuchmann merged commit 4480732 into aristanetworks:devel Jul 28, 2022
CA-PROJECT-03 automation moved this from In progress to Done Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippebureau philippebureau philippebureau approved these changes

@tgodaA tgodaA tgodaA approved these changes

@lermilov lermilov Awaiting requested review from lermilov

Assignees

@carlbuchmann carlbuchmann

Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
CA-PROJECT-03
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carlbuchmann @philippebureau @tgodaA @ClausHolbechArista