Feat(eos_cli_config_gen): Add key_type for ntp.authentication_keys

[philippebureau]

Change Summary

adding key_type under ntp in eos_cli_config_gen
To prevent impact on existing implementations, the current behaviour will be preserved until AVD 4.0.0 (see release notes)
Starting with AVD 4.0.0, if no key type is defined, type 7 will be default.

Related Issue(s)

Fixes #2211

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add a variable to define ntp encryption key type and define with type 7, 8a and no key for ntp authentication keys

example ( key 1 will use no key (old behaviour), key 2 type 7 and key 3 type 8a)

  authentication_keys:
    - id: 1
      hash_algorithm: "md5"
      key: "7 044F0E151B"
    - id: 2
      hash_algorithm: "md5"
      key: "044F0E151B"
      key_type: 7
    - id: 3
      hash_algorithm: "sha1"
      key: "$BYk2Sjahe+D9T7uDgIItSA==$JTw5JOAPcYEo0O2hsvsxFQ==$C7wmpXOo"
      key_type: 8a

How to test

tested without key_type set to confirm type 7 is used and test with other values

output in molecule:

ntp authentication-key 1 md5 7 044F0E151B
ntp authentication-key 2 md5 7 044F0E151B
ntp authentication-key 3 sha1 8a $BYk2Sjahe+D9T7uDgIItSA==$JTw5JOAPcYEo0O2hsvsxFQ==$C7wmpXOo

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[ClausHolbechArista]

While I agree this is a fix since the documentation is misleading, this is also a breaking change for ppl who have worked around the issue by using a clear-text password or by inserting 7 before their password.
@carlbuchmann
Maybe worth postponing to 4.x or at the very least call it out in more detail in release-notes?
Please add a description to draft release-notes as part of this PR.
Alternatively we could remove the default 7 in this PR, and only add the type if it is specifically set. Then the behavior would be 1:1 for existing deployments. We can then add the default in 4.0.

[philippebureau]

updated the ntp.j2 template with @ClausHolbechArista inputs

[gmuloc]

some small comment that can be ignored if you feel that's enough.

LGTM

[gmuloc]

Probably worth stating what the previous behavior is in this otherwise as a common user I don't know where to look for it.

[carlbuchmann]

I think it's enough for this context - we will capture more info on this in 4.0 when behavior changes.