Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add support for multiple descriptions for l3_interfaces #2291

Merged
merged 3 commits into from Dec 13, 2022

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Nov 23, 2022

Change Summary

Add the ability to have a list of descriptions for l3_interfaces

Related Issue(s)

Fixes #2236

Component(s) name

arista.avd.eos_designs

Proposed changes

Documentation

The code checks for the presence of descriptions and make sure the length of the list is as long as the list of interfaces. If so each interface is assigned the description at the same index in the descriptions table.
descriptions takes precedence over the existing description

-        # This will create IP routed interface inside VRF. Length of interfaces, nodes and ip_addresses must match.
+        # This will create IP routed interface inside VRF. Length of interfaces, nodes and ip_addresses and descriptions (if used) must match.
         l3_interfaces:
           - interfaces: [ <interface_name1>, <interface_name2>, <interface_name3> ]
             ip_addresses: [ <IPv4_address/Mask>, <IPv4_address/Mask>, <IPv4_address/Mask> ]
             nodes: [ < node_1 >, < node_2 >, < node_1 > ]
             description: < description >
+            # `descriptions` has precedence over `description`
+            descriptions: [ <description1>, <description2>, description3> ]
             enabled: < true | false >
             mtu: < mtu >
             # EOS CLI rendered directly on the Ethernet interface in the final EOS configuration

How to test

molecule in eos_designs_unit_test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested a review from a team as a code owner November 23, 2022 13:26
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated state: conflict PR with conflict labels Nov 23, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@carlbuchmann carlbuchmann added this to the v3.8.0 milestone Nov 24, 2022
@ClausHolbechArista ClausHolbechArista requested a review from a team December 6, 2022 07:35
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 326d21d into aristanetworks:devel Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): support multiple descriptions in network_services l3_interface rather than a unique one
6 participants