New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add support for multiple descriptions for l3_interfaces #2291
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
...lections/arista/avd/roles/eos_designs/python_modules/network_services/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
...a/avd/molecule/eos_designs_unit_tests/inventory/group_vars/DC1_TENANTS_NETWORKS/Tenant_A.yml
Outdated
Show resolved
Hide resolved
Conflicts have been resolved. A maintainer will review the pull request shortly. |
...lections/arista/avd/roles/eos_designs/python_modules/network_services/ethernet_interfaces.py
Show resolved
Hide resolved
...lections/arista/avd/roles/eos_designs/python_modules/network_services/ethernet_interfaces.py
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/doc/network-services-v4.0.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Change Summary
Add the ability to have a list of descriptions for l3_interfaces
Related Issue(s)
Fixes #2236
Component(s) name
arista.avd.eos_designs
Proposed changes
Documentation
The code checks for the presence of
descriptions
and make sure the length of the list is as long as the list ofinterfaces
. If so each interface is assigned the description at the same index in thedescriptions
table.descriptions
takes precedence over the existingdescription
How to test
molecule in
eos_designs_unit_test
Checklist
User Checklist
Repository Checklist